original argmap fixes: argmap2mup and pandoc-argmap.lua#3
Open
s6mike wants to merge 8 commits intodsanson:masterfrom
Open
original argmap fixes: argmap2mup and pandoc-argmap.lua#3s6mike wants to merge 8 commits intodsanson:masterfrom
s6mike wants to merge 8 commits intodsanson:masterfrom
Conversation
- Fork of https://github.com/dsanson/argmap - argmap2mup fix (potentially caused by different lua version): - Close #1 starts file with nil - Close #2 gdrive upload fails - Update license and readme. - Add conda export: environment.yml, .gitignore and this NEWS.md file.
- to start from 1.0.1 to reflect dsanson's original repo
- Updated my changes to start from 1.1.0 for continuity
- Update README.
- Update [README](README.markdown).
- Rename this file to docs/CHANGELOG.md - Refined conda install environment.
Fix crashes for 2 README md to pdf examples. Close #19. - Update `.gitignore`
Author
|
Oops, just realised the rebase I did on this branch to clean up some commit messages included your very last commit when you added a reference to my fork. So although it looks the same, it's actually a different commit. Think in practice it's unlikely to matter much. Anyway I'm not going to try and fix it, I'd probably make things worse. The original PR's branch is still available, so if you decide to use that instead we can sort that out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just broke my previous PR by renaming the branch, so here's a new PR from a new branch, same as before just with 1 extra fix for
pandoc-argmap.lua.Right now I don't plan to update this branch further or send any more PRs, but if you do want any additional fixes included in the future, please do let me know.
Original PR:
Mainly fixing 2 issues I had with argmap2mup not working. Possible that I'm using a different lua version to you (I'm using 5.3.4) and this has caused the issues.
There should be more fixes to follow since Mindmup still doesn't seem to like the uploaded GDrive files.
FYI this is my first ever pull request, and my first time using Lua, so apologies for any mistakes on my part. Feedback welcome!
argmap2mup fix (potentially caused by different lua version):
Close Issue 1 output file starts with 'nil'
Close Issue 2 gdrive upload fails
Update license and readme.
Add conda export: environment.yml, .gitignore and this NEWS.md file.