Better download mechanism with aria2c and code beautified#698
Open
angoca wants to merge 6 commits intodrolbr:masterfrom
Open
Better download mechanism with aria2c and code beautified#698angoca wants to merge 6 commits intodrolbr:masterfrom
angoca wants to merge 6 commits intodrolbr:masterfrom
Conversation
|
This patch doesen't appear to do anything to address aria2c being a new dependency, while It could be improved helping to get But before doing all that, it would be useful to provide some benchmarks to demonstrate that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced wget for aria2c, which provides better control for parallel downloads, and to continue when the script got canceled.
Also, I ran shellcheck to improve the robustness of the script.
Finally, I added some bash flags to validate the correct execution.