Fix "Downloading .NET..." status bar indicator not clearing after download completes#2607
Draft
Fix "Downloading .NET..." status bar indicator not clearing after download completes#2607
Conversation
Co-authored-by: nagilson <23152278+nagilson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect status message for .NET downloading
Fix "Downloading .NET..." status bar indicator not clearing after download completes
Mar 11, 2026
nagilson
reviewed
Mar 11, 2026
| } | ||
|
|
||
| export class StatusBarObserver implements IEventStreamObserver { | ||
| private readonly inProgressDownloads: string[] = []; |
Member
There was a problem hiding this comment.
I dont think this would properly handle 2 simultaneous requests of the same version-component-arch / install id since the id can be the same depending on that, which is the common case (c# and c#dk ask to acquire the same thing at startup) so we should see how that works (what events are published in this case, are both published or not, I think they are) + test it. otherwise seems prettysolid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatusBarObserverhad no awareness of concurrent downloads — it hid the status bar on the firstDotnetAcquisitionCompletedevent received, even if other downloads were still in progress. It also never handledDotnetAcquisitionFinalError, leaving the indicator permanently visible on download failure.Changes
StatusBarObserver: AddinProgressDownloads: string[]tracking (consistent withOutputChannelObserver) to gateresetAndHideStatusBar()on all downloads finishing:DotnetAcquisitionStart→ pushinstallId, show indicatorDotnetAcquisitionCompleted/DotnetInstallExpectedAbort→ removeinstallId, hide if emptyDotnetAcquisitionFinalError(new) → removeinstallId, hide if empty (indicator was stuck forever on failure)DotnetAcquisitionError→ unchanged (always show error state)StatusBarObserver.test.ts: New unit tests covering single download lifecycle, concurrent download tracking (stays visible while any download is in progress), abort, and final-error scenarios.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
microsoft.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/vscode-dotnet-runtime/vscode-dotnet-runtime/vscode-dotnet-runtime-library/node_modules/.bin/mocha -u tdd -- dist/test/unit/DebianDistroTests.test.js dist/test/unit/DotnetConditionValidator.test.js dist/test/unit/DotnetCoreAcquisitionWorker.test.js dist/test/unit/DotnetPathFinder.test.js dist/test/unit/DotnetResolver.test.js dist/test/unit/ErrorHandler.test.js dist/test/unit/ExecutableArchitectureDetector.test.js dist/test/unit/ExistingPathResolver.test.js dist/test/unit/GlobalInstallerResolver.test.js dist/test/unit/InstallScriptAcquisitionWorker.test.js dist/test/unit/InstallTracker.test.js dist/test/unit/InstallationValidator.test.js dist/test/unit/IssueReporter.test.js dist/test/unit/JsonInstaller.test.js dist/test/unit/LinuxDistroTests.test.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.