Use install state in workload manifest provider

[dsplaisted]

This PR contains a bug fix and a feature.

Bug Fix

Description

Fixes issue where when reading side-by-side workload manifests, the Manifest ID would be reported incorrectly.

Customer Impact

If this change doesn't go into 7.0.4xx / VS 17.7, then VS 17.7 and its version of MSBuild will not work properly with future builds of the .NET 8 SDK (once we switch to side-by-side workload manifests). The behavior will either be that the resolver will crash, preventing builds from succeeding, or that it won't successfully load any workloads.

Regression?

• Yes
• No - This was a bug introduced in a new feature (in Support side by side workload manifests in SDK resolver #32471), and doesn't occur if the new feature (side-by-side workload manifests) isn't used.

Risk

• High
• Medium
• Low

Verification

• Manual
• Automated

Feature

Description

Implements last part of resolver logic for dotnet/designs#294, which is to honor workload install state. This will support commands which install a different workload set version, for example dotnet workload update --version 8.0.101.

Customer Impact

If this change doesn't go into 7.0.4xx / VS 17.7, then in some cases where a command is run that selects a specific workload set version, that would not be honored by Visual Studio 17.7 and its version of MSBuild.

A workaround would be to specify the desired workload set version in a global.json file.

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual
• Automated

[Forgind]

Any chance you could isolate the changes that were just moving things from one class to another from the changes that had substantive code impact? The line count is high, but a lot of the early parts especially were just moving code 🙂

[dsplaisted]

Any chance you could isolate the changes that were just moving things from one class to another from the changes that had substantive code impact? The line count is high, but a lot of the early parts especially were just moving code 🙂

@Forgind I've rebased the code moves into separate commits.

[dsplaisted]

@jaredpar This commit seems to have caused the Full Framework CI leg to time out. Is returning a ref struct from a method not supported or handled differently on .NET Framework?