AsyncObseravableBase: Fix in case of exceptions thrown synchronously#2213
Open
fedeAlterio wants to merge 5 commits intodotnet:mainfrom
Open
AsyncObseravableBase: Fix in case of exceptions thrown synchronously#2213fedeAlterio wants to merge 5 commits intodotnet:mainfrom
fedeAlterio wants to merge 5 commits intodotnet:mainfrom
Conversation
fedeAlterio
force-pushed
the
fix/synchronous-exceptions-asyncobservable
branch
from
83a0b5c to
b0a3736
Compare
fedeAlterio
force-pushed
the
fix/synchronous-exceptions-asyncobservable
branch
from
b0a3736 to
f25ab7d
Compare
Author
|
@idg10 There isn’t an open issue for these problems, but the code comments describe them in detail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IAsyncObserver<T> OnNextAsync, OnCompletedAsync and OnErrorAsynccan all throw exceptions synchronously,This is not handled correctly in AsyncObseravableBase, and the execution flow will follow a different path of the asynchronous one.
A concrete issue caused by this, is that if a synchoronous exception is thrown inside OnCompleteAsync,
AutoDetachAsyncObserverwill not Dispose the subscription automaticallyFixes also reentrancy issues when Disposing while in the middle of an On*Async call