Skip to content

refactor: remove wasm args#5134

Open
FreyLuis wants to merge 2 commits intodotnet:mainfrom
FreyLuis:remove-wasm-args
Open

refactor: remove wasm args#5134
FreyLuis wants to merge 2 commits intodotnet:mainfrom
FreyLuis:remove-wasm-args

Conversation

@FreyLuis
Copy link

@FreyLuis FreyLuis commented Mar 2, 2026

This PR removes both wasmArgs.

--module is now added by BenchmarkDotNet when running on V8 (dotnet/BenchmarkDotNet#3020).
--expose_wasm is obsolete and was removed from V8 in 2024.

@FreyLuis FreyLuis force-pushed the remove-wasm-args branch 3 times, most recently from dd6ee14 to 33eabba Compare March 3, 2026 10:35
@FreyLuis
Copy link
Author

FreyLuis commented Mar 3, 2026

@ilonatommy @timcassell Is there some manual part in publishing benchmarkdotnet nightlies, or have I missed something?

In the failing CI runs, it can't find the nightly that I've referenced, but it works for the scenario pipelines...

error NU1102:   - Found 75 version(s) in benchmark-dotnet-prerelease [ Nearest version: 0.16.0-nightly.20260226.451 ]

@ilonatommy
Copy link
Member

@ilonatommy @timcassell Is there some manual part in publishing benchmarkdotnet nightlies, or have I missed something?

Yes, it's tricky. In my case I was getting the version from @LoopedBard3 and that one always worked properly.

@LoopedBard3
Copy link
Member

Yes, we have a mirror for nightlies that we have to manually update (but we are looking into options for automatic mirroring). I will get this version mirrored and retested today 👍.

@FreyLuis
Copy link
Author

FreyLuis commented Mar 3, 2026

Thank you

@LoopedBard3 LoopedBard3 self-assigned this Mar 3, 2026
@LoopedBard3 LoopedBard3 requested a review from Copilot March 3, 2026 18:13
@LoopedBard3
Copy link
Member

/azp run

@LoopedBard3
Copy link
Member

The feed should be available, rerunning the checks.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the --expose_wasm and --module V8 wasm arguments from benchmark scripts. --expose_wasm was removed from V8 in 2024, and --module is now automatically added by BenchmarkDotNet when running on V8 (via BDN PR #3020). The PR also bumps the BDN nightly version to include that fix.

Changes:

  • Remove --wasmArgs (containing --expose_wasm and --module) from WASM benchmark run configurations in CI and local scripts
  • Update BenchmarkDotNet to nightly 0.16.0-nightly.20260302.459 which automatically adds --module for V8
  • Update documentation examples to remove the now-unnecessary --wasmArgs and --wasmDataDir arguments

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
scripts/run_performance_job.py Removes wasm_args construction and --wasmArgs BDN argument for both wasm and wasm_coreclr runtime types
scripts/benchmarks_local.py Removes --wasmArgs from WasmInterpreter and WasmAOT run types, but leaves behind stale comments referencing --wasmArgs
eng/Versions.props Bumps BDN version to nightly 20260302.459, which includes the fix to auto-add --module for V8
docs/benchmarking-workflow-dotnet-runtime.md Removes --wasmArgs=\"--module\" and --wasmDataDir from interpreter and AOT benchmark doc examples

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LoopedBard3 LoopedBard3 removed their assignment Mar 3, 2026
FreyLuis added 2 commits March 4, 2026 11:58
- `--expose_wasm` is obsolete
- `--module` is now set by benchmarkdotnet
@FreyLuis FreyLuis marked this pull request as ready for review March 4, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants