[UIKit] Enable nullability and clean up UISearchDisplayController. #24686
Conversation
This is file 21 of 30 files with nullability disabled in UIKit. * Enable nullability (#nullable enable). * Remove unused using directives (System.Drawing, CoreFoundation, CoreAnimation, CoreLocation, MapKit, UIKit, CoreGraphics). * Make SearchResultsSource nullable (UITableViewSource?) since the getter returns null when the delegate is not a UITableViewSource. * Simplify getter by returning the 'as' cast directly instead of assigning to a variable and checking for null. * Improve XML documentation comments: remove 'To be added.' placeholders, use 'Gets or sets' phrasing, add 'see cref' reference. Contributes towards #17285.
There was a problem hiding this comment.
Pull request overview
Enables nullable reference types for UISearchDisplayController’s convenience API and updates the related documentation/cleanup to better reflect actual runtime behavior in the UIKit binding surface.
Changes:
- Enabled
#nullableinUISearchDisplayController.csand removed now-unneededusingdirectives. - Updated
SearchResultsSourcetoUITableViewSource?and simplified its getter to return theascast directly. - Cleaned up XML documentation by removing placeholder content and improving wording.
✅ [PR Build #bee0ddb] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #bee0ddb] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #bee0ddb] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #bee0ddb] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #bee0ddb] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #bee0ddb] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #bee0ddb] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
❌ [CI Build #bee0ddb] Tests on macOS arm64 - Mac Tahoe (26) failed ❌Failed tests are:
Pipeline on Agent |
🚀 [CI Build #bee0ddb] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 124 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
3 participants
This is file 21 of 30 files with nullability disabled in UIKit.
CoreAnimation, CoreLocation, MapKit, UIKit, CoreGraphics).
getter returns null when the delegate is not a UITableViewSource.
assigning to a variable and checking for null.
use 'Gets or sets' phrasing, add 'see cref' reference.
Contributes towards #17285.