[UIKit] Enable nullability and clean up UIPopoverPresentationController. #24684
Conversation
This is file 19 of 30 files with nullability disabled in UIKit. * Enable nullability (#nullable enable). * Make PopoverBackgroundViewType nullable (Type?) since the getter can return null when no background view class is set. * Improve XML documentation comments: remove 'To be added.' placeholders, fix formatting. Contributes towards #17285.
There was a problem hiding this comment.
Pull request overview
Enables nullable reference types for UIPopoverPresentationController in UIKit, aligning this file with the ongoing effort to incrementally add nullability annotations across the framework.
Changes:
- Enabled
#nullableinUIPopoverPresentationController.cs. - Updated
PopoverBackgroundViewTypetoType?to accurately represent that it can returnnull. - Cleaned up XML documentation by removing placeholder content.
✅ [PR Build #4cacbb6] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #4cacbb6] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #4cacbb6] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #4cacbb6] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #4cacbb6] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #4cacbb6] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #4cacbb6] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #4cacbb6] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #4cacbb6] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 130 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
3 participants
This is file 19 of 30 files with nullability disabled in UIKit.
can return null when no background view class is set.
fix formatting.
Contributes towards #17285.