[net11.0] Exclude debug libraries in Release builds #24680
Conversation
kotlarmilos
requested review from
emaf,
mauroa and
rolfbjarne
as code owners
| } | ||
|
|
||
| if (Platform != Utils.ApplePlatform.MacOSX && string.Equals (Configuration, "Release", StringComparison.OrdinalIgnoreCase)) { | ||
| // libmscordaccore and libmscordbi are debug-only libraries, don't include them in Release builds on mobile platforms |
There was a problem hiding this comment.
What are these libraries used for? Debugger support? Profiling? Anything else?
There was a problem hiding this comment.
I think these are debugger libs. It might get changed soon
There was a problem hiding this comment.
I was asking mostly to see if there's a better condition than "Configuration=Release", because that doesn't work if customers have a different release configuration, say "Configuration=AppStore".
We could for instance use the DebuggerSupport property:
There was a problem hiding this comment.
Sounds good, updated
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #dc203ec] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #dc203ec] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #dc203ec] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 19 tests failed, 120 tests passed. Failures❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests7 tests failed, 37 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)9 tests failed, 4 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (MacCatalyst)1 tests failed, 16 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)1 tests failed, 12 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
…te logic to exclude debug libraries in Release builds
…otnet/macios into dev/exclude-libmscor-libraries
3 participants
Description
This PR excludes libmscordaccore and libmscordbi from the bundle in Release builds as they are not used.
In a MAUI sample app, this reduced the device Release app bundle size for 3.08 MB.