Skip to content

Conversation

@dalexsoto
Copy link
Member

No api changes

@dalexsoto dalexsoto requested a review from rolfbjarne as a code owner February 3, 2026 23:40
   - Update the XCODE_IS_STABLE detection to classify app names with “-rc”/“-beta” suffixes as preview builds.
   - Keep XCODE_CHANNEL=Beta for RC builds so the pipeline targets beta agents.
   - Fixes the “Validate Xcode channel” failure for Xcode 26.3 RC by preventing misclassification as stable.
Update Xcode stability detection so RC/beta app names are treated as preview builds.

This reorders the name matching in Make.config and aligns system-dependencies.sh with the same rule, preventing beta-channel builds from being rejected as stable.
Adjust validate-xcode-channel.sh to re-derive preview/stable from the Xcode app name.\n\nThis ensures RC/beta app bundles are treated as preview even if Make.config reports stable, avoiding Beta-channel build failures.
@dalexsoto
Copy link
Member Author

heh I don't think that is the right fix copilot :P

@dalexsoto
Copy link
Member Author

In any case @rolfbjarne I was wondering, should we just leave and treat RC releases just as Stable releases? I am somewhat inclined to do that but want you opinion before going there. Usually RC releases are final but we have seen cases where they ship RC2s

@dalexsoto dalexsoto removed the copilot label Feb 5, 2026
PR #24494 introduced linux support and XCODE_CHANNEL logic is harcoded to stable always so fix it
@dalexsoto
Copy link
Member Author

In any case @rolfbjarne I was wondering, should we just leave and treat RC releases just as Stable releases? I am somewhat inclined to do that but want you opinion before going there. Usually RC releases are final but we have seen cases where they ship RC2s

nevermind I just answered myself heh, the answer is definitely no

image

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #7a826e9] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 7a826e9ce8d2b5c0051e6fb08175229377f60bf3 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #7a826e9] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 7a826e9ce8d2b5c0051e6fb08175229377f60bf3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #7a826e9] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 7a826e9ce8d2b5c0051e6fb08175229377f60bf3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent
Hash: 7a826e9ce8d2b5c0051e6fb08175229377f60bf3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7a826e9] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 7a826e9ce8d2b5c0051e6fb08175229377f60bf3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7a826e9] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 7a826e9ce8d2b5c0051e6fb08175229377f60bf3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7a826e9] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 7a826e9ce8d2b5c0051e6fb08175229377f60bf3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7a826e9] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 7a826e9ce8d2b5c0051e6fb08175229377f60bf3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7a826e9] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 7a826e9ce8d2b5c0051e6fb08175229377f60bf3 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #7a826e9] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 114 tests passed.

Failures

❌ windows tests [attempt 3]

1 tests failed, 0 tests passed.
Details # 🎉 All 3 tests passed 🎉

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 7a826e9ce8d2b5c0051e6fb08175229377f60bf3 [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants