Make ML.NET tests target net8.0 and net9.0 instead of net6.0#7097
Closed
ericstj wants to merge 27 commits intodotnet:mainfrom
Closed
Make ML.NET tests target net8.0 and net9.0 instead of net6.0#7097ericstj wants to merge 27 commits intodotnet:mainfrom
ericstj wants to merge 27 commits intodotnet:mainfrom
Conversation
Net6 & net7 will be out of support by the time we release.
InternalDataKind.TX and InternalDataKind.Text have the same underlying value. In net8.0 we started seeing ToString return the latter.
Member
Author
|
I may go ahead and do the refactoring of the build pipeline to stop passing in the test TFM. That's a bit of a hack and it's what's causing one set of the failures here. |
Rather than constructing the test information outside the projects make a target within the test reponsible for this. That allows us to avoid hardcoding paths, and directly control the behavior for the individual test at the project level.
Member
Author
|
Ok, I rewrote how we compose the test payloads. This makes this more distributed and will give tests the ability to control this in the project and targets - and removes that complexity from the pipeline. |
Member
Author
|
Getting closer here. Most remaining failures are on Arm and need unique baseline updates. I'm thinking to add a test script used by the tests that copies any outputs on failure (to aide in updating baselines). This will also let me fix the double reporting of failures. |
Test script saves test output on failures. It also avoids returning non-zero when the runner completes gracefully with failures.
Also cleanup setting RuntimeIdentifier since it's not required. Techincally we could be testing .NETFramework on more architectures by setting PlatformTarget but I don't want to open that can of worms yet since it might require new sets of baselines.
Member
Author
|
Closing this now as it's largely taken care of with @michaelgsharp's latest PR. #7319 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a portion of the work from #6749
This moves the tests forward to net8.0, and cleans up RemoteExecutor (which I noticed in @tarekgh's PR).
I minimized the product changes so as to not break compat (thought CPU math is changing it's TFM based on net6.0 going OOS by Nov).
Where possible I tried to use
NetMinimumandNetCurrentto make this easier next time.I'm not thrilled about all the TFM duplication in the PR pipeline. I think we should clean that up in a follow-up PR though.