Skip to content

Expand all contractions except those used as examples.#1601

Merged
jskeet merged 1 commit intodotnet:draft-v8from
Nigel-Ecma:contractions
Mar 11, 2026
Merged

Expand all contractions except those used as examples.#1601
jskeet merged 1 commit intodotnet:draft-v8from
Nigel-Ecma:contractions

Conversation

@Nigel-Ecma
Copy link
Contributor

Fixes #1596

While the “vote” on 1596 is 100% for this, it is hardly representative! ;-) However there is a meeting shortly so I’m clearing my desk and pushing this out.

@Nigel-Ecma Nigel-Ecma added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Mar 10, 2026
@Nigel-Ecma
Copy link
Contributor Author

Note that since #1596 I found one case where a contraction is used as an example, see lexical-structure.md lines 1439 & 1444, so a simple F&R addition to Smarten to do this automatically wouldn’t be so simple and likely fragile (if it looked for the exception). When I first wrote Smarten I did consider whether a “don’t smarten” tag might be needed in the text on occasions, I decided not at the time… Maybe checking for stray contractions will need to be a pre-publishing manual check.

Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upvoted 1596, and these changes look good to me.

@jskeet
Copy link
Contributor

jskeet commented Mar 11, 2026

Any reason not to update the example as well? For the example you've given, I think we could easily change the message.

One place which could be tricky is where we've taken text from other documentation, e.g. in the standard library. It looks like this PR doesn't change any of those files - is that because there were no changes to make, or because you excluded them from your F&R?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM as well.

@Nigel-Ecma
Copy link
Contributor Author

@jskeet wrote:

Any reason not to update the example as well? For the example you've given, I think we could easily change the message.

Reason: I was just trying to fix the language and not overload the PR ;-)

One place which could be tricky is where we've taken text from other documentation, e.g. in the standard library. It looks like this PR doesn't change any of those files - is that because there were no changes to make, or because you excluded them from your F&R?

They were not excluded. I did consider excluding text in comments, as they might be seen as informal, but decided against it. I suggest an attributed in-text quote should remain true to the source, but would not be concerned over text we derive from library documentation as we invariably edit that anyway.

@jskeet jskeet merged commit 089fae9 into dotnet:draft-v8 Mar 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meeting: discuss This issue should be discussed at the next TC49-TG2 meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

To contract or not to contract, that is the question ;-)

3 participants