Expand all contractions except those used as examples.#1601
Expand all contractions except those used as examples.#1601jskeet merged 1 commit intodotnet:draft-v8from
Conversation
|
Note that since #1596 I found one case where a contraction is used as an example, see |
jskeet
left a comment
There was a problem hiding this comment.
Upvoted 1596, and these changes look good to me.
|
Any reason not to update the example as well? For the example you've given, I think we could easily change the message. One place which could be tricky is where we've taken text from other documentation, e.g. in the standard library. It looks like this PR doesn't change any of those files - is that because there were no changes to make, or because you excluded them from your F&R? |
|
@jskeet wrote:
Reason: I was just trying to fix the language and not overload the PR ;-)
They were not excluded. I did consider excluding text in comments, as they might be seen as informal, but decided against it. I suggest an attributed in-text quote should remain true to the source, but would not be concerned over text we derive from library documentation as we invariably edit that anyway. |
Fixes #1596
While the “vote” on 1596 is 100% for this, it is hardly representative! ;-) However there is a meeting shortly so I’m clearing my desk and pushing this out.