Skip to content

CoreClr uses WASM sdk #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timcassell merged 4 commits into from
Feb 20, 2026
+20 −4
Merged

CoreClr uses WASM sdk #3018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c2abfc
Use WASM sdk for coreclr and allow running with nodeJS.
ilonatommy Feb 20, 2026
fd47555
Cleanup.
ilonatommy Feb 20, 2026
12e3cb2
Revert transition to nodeJS - v8 newer than 10.8 works fine.
ilonatommy Feb 20, 2026
89a8135
Fix version.
ilonatommy Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/BenchmarkDotNet/Portability/RuntimeInformation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ internal static string GetRuntimeVersion()
}
}

return $".NET Core (Mono) {versionString}";
string runtimeName = IsMono ? "Mono" : "CoreCLR";
return $".NET Core ({runtimeName}) {versionString}";
}
else if (IsOldMono)
{
Expand Down
2 changes: 1 addition & 1 deletion src/BenchmarkDotNet/Templates/WasmCsProj.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</PropertyGroup>

<Import Project="$(WasmPropsPath)" Condition="Exists($(WasmPropsPath))" />

$CORECLR_OVERRIDES$
<PropertyGroup>
<OutputType>Exe</OutputType>
<RuntimeConfig>Release</RuntimeConfig>
Expand Down
19 changes: 17 additions & 2 deletions src/BenchmarkDotNet/Toolchains/MonoWasm/WasmGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,22 @@ protected void GenerateProjectFile(BuildPartition buildPartition, ArtifactsPaths
var xmlDoc = new XmlDocument();
xmlDoc.Load(projectFile.FullName);
var (customProperties, _) = GetSettingsThatNeedToBeCopied(xmlDoc, projectFile);
// Microsoft.NET.Sdk.WebAssembly auto-defaults UseMonoRuntime=true.
string sdkName = runtime.IsMonoRuntime ? "Microsoft.NET.Sdk.WebAssembly" : "Microsoft.NET.Sdk";
string sdkName = "Microsoft.NET.Sdk.WebAssembly";

// For CoreCLR WASM:
// - UseMonoRuntime=false: resolves CoreCLR runtime pack instead of Mono
// - WasmBuildNative=false: avoids requiring wasm-tools workload
// - WasmEnableWebcil=false: CoreCLR doesn't support webcil format
string coreclrOverrides = runtime.IsMonoRuntime
? string.Empty
: @"
<!-- CoreCLR overrides: use CoreCLR runtime instead of Mono -->
<PropertyGroup>
<UseMonoRuntime>false</UseMonoRuntime>
<WasmBuildNative>false</WasmBuildNative>
<WasmEnableWebcil>false</WasmEnableWebcil>
</PropertyGroup>
";

string content = new StringBuilder(ResourceHelper.LoadTemplate("WasmCsProj.txt"))
.Replace("$PLATFORM$", buildPartition.Platform.ToConfig())
Expand All @@ -60,6 +74,7 @@ protected void GenerateProjectFile(BuildPartition buildPartition, ArtifactsPaths
.Replace("$SDKNAME$", sdkName)
.Replace("$WASMDATADIR$", runtime.WasmDataDir)
.Replace("$TARGET$", CustomRuntimePack.IsNotBlank() ? "PublishWithCustomRuntimePack" : "Publish")
.Replace("$CORECLR_OVERRIDES$", coreclrOverrides)
.ToString();

File.WriteAllText(artifactsPaths.ProjectFilePath, content);
Expand Down