Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes several improvements to the DotNetCampus.ModelContextProtocol library:
- Exposes the registered transport layer list to consumer code through a new
McpServer.Transportsproperty (backed by aList<IServerTransport>instead ofHashSet<IServerTransport>). - Centralizes common NuGet package build settings (AOT compatibility, symbols, SourceLink, etc.) into a shared
build/Package.propsfile, promoting reuse across multiple projects. - Optimizes AI-model-facing descriptions by switching from inline
(Values: ...)format to a newline-separated format for enum values and polymorphic type hints.
Changes:
- Expose transport list via
McpServer.Transportsand switch backing store fromHashSettoListwith manual dedup - Extract common package build properties into
build/Package.props; update Ipc and TouchSocket.Http projects to import it and target multiple frameworks
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
ServerTransportManager.cs |
_transports changed from HashSet to List with explicit duplicate check; new Transports property exposed |
McpServer.cs |
New public Transports property delegating to ServerTransportManager.Transports |
build/Package.props |
New shared file centralizing NuGet packaging properties and SourceLink reference |
Directory.Build.props |
Removes per-project Description (now set per-project in each .csproj) |
DotNetCampus.ModelContextProtocol.csproj |
Imports Package.props; removes properties now in shared file |
DotNetCampus.ModelContextProtocol.TouchSocket.Http.csproj |
Imports Package.props; expands to multi-framework; adds Compatibility.cs link |
DotNetCampus.ModelContextProtocol.Ipc.csproj |
Imports Package.props; removes IsPackable=false; adds missing package references |
McpServerToolSourceBuilder.cs |
Switches to ToNullableDisabledGlobalDisplayString() for AOT-safe generic type arguments |
JsonPropertySchemaInfo.cs |
Changes enum/polymorphic hint format from inline (Values: ...) to newline-separated |
DotNetCampus.ModelContextProtocol.sln |
Adds build/Package.props to solution view |
src/DotNetCampus.ModelContextProtocol.Analyzer/Generators/Models/JsonPropertySchemaInfo.cs
Outdated
Show resolved
Hide resolved
src/DotNetCampus.ModelContextProtocol.Analyzer/Generators/Models/JsonPropertySchemaInfo.cs
Outdated
Show resolved
Hide resolved
lindexi
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.