Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
Member
Author
|
@rumpl synctest.Test just for you |
There was a problem hiding this comment.
Code Review Summary
Reviewed the changes to speed up fallback tests by using testing/synctest.Test() with fake time instead of real time delays.
Changes Analyzed
- Added
testing/synctestimport - Wrapped 7 test functions with
synctest.Test(t, func(t *testing.T) {...}) - Removed
t.Parallel()calls (synctest runs serially with deterministic scheduling) - Removed elapsed time assertions (no longer needed with fake time)
- Replaced
require.Eventually()withtime.Sleep()+ direct assertion in TestFallbackCooldownState
Verification
✅ All CI tests pass (test: SUCCESS)
✅ The use of synctest.Test() with streaming operations works correctly
✅ The fake clock properly synchronizes time.Sleep() and time.Now() calls
✅ The cooldown expiration logic works correctly with fake time
Findings
No issues found. The changes correctly implement test speedup using Go's testing/synctest package. The fake time scheduling is properly synchronized, and all tests pass.
Verdict: APPROVE ✓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.