Fix Python 3.9: _get_class_annotations inherits parent annotations via getattr MRO traversal#18
Merged
harumaki4649 merged 2 commits intomainfrom Mar 8, 2026
Merged
Conversation
Co-authored-by: harumaki4649 <83683593+harumaki4649@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI configuration for Python 3.9 errors
Fix Python 3.9: _get_class_annotations inherits parent annotations via getattr MRO traversal
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3.9,
getattr(cls, '__annotations__')traverses the MRO and returns a parent class's annotations dict when the child declares none. Python 3.10+ fixed this to return{}instead — causing_class_to_schema()to silently include inherited fields only on 3.9.Changes
_get_class_annotations: Added an object-identity guard after thegetattrfallback. If the returned mapping is the same object (is) as any base class's own__annotations__, it's MRO-inherited and we return{}instead.getattrfallback for metaclass-defined__annotations__properties (lazily computed annotations), since those return a freshly constructed dict each time — neveris-identical to a base class's annotations.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.