Fix diagnostic messages and add parser documentation#13
Merged
quinchs merged 3 commits intodiscord-net:mainfrom Jan 5, 2026
Merged
Fix diagnostic messages and add parser documentation#13quinchs merged 3 commits intodiscord-net:mainfrom
quinchs merged 3 commits intodiscord-net:mainfrom
Conversation
Contributor
M1tsumi
commented
Jan 3, 2026
M1tsumi
commented
- Fixed DC0003 diagnostic to show 'Value out of range' instead of 'Type mismatch'
- Improved message format to include property name and constraint details
- Added XML documentation for IsIncremental explaining incremental parsing behavior
- Added XML documentation for Width property clarifying direct vs tree-wide counting
- Replaced empty string literals with string.Empty to avoid .NET 9.0.308 compiler crash
- Fixed DC0003 diagnostic to show 'Value out of range' instead of 'Type mismatch' - Improved message format to include property name and constraint details - Added XML documentation for IsIncremental explaining incremental parsing behavior - Added XML documentation for Width property clarifying direct vs tree-wide counting - Replaced empty string literals with string.Empty to avoid .NET 9.0.308 compiler crash
Fix diagnostic messages and add parser documentation
quinchs
requested changes
Jan 5, 2026
Contributor
Author
|
Thanks for the quick review, and I 100% see the issue and thats my bad on not catching it beforehand. I replaced the width documentation with |
quinchs
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.