PTE Apps and Nuget for getting versions #73
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new PTE (Per Tenant Extension) Apps management feature that integrates with NuGet package repositories to track and retrieve app versions. The implementation supports GitHub and Azure DevOps as DevOps platforms, using their respective NuGet feeds to fetch available app versions via REST API calls.
Key changes:
- New PTE Apps and PTE App Versions tables with associated UI pages
- NuGet integration using REST client to query package versions from GitHub and Azure DevOps
- DevOps organization management with PAT token storage
- Integration with existing PTE Object Range functionality
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| D4PBCNugetProcessing.Codeunit.al | Core logic for retrieving and processing PTE app versions from NuGet feeds |
| D4PBCGitHubUpdate.Codeunit.al | GitHub-specific implementation for NuGet service discovery and authentication |
| D4PBCAzureUpdate.Codeunit.al | Azure DevOps implementation for NuGet service access (currently disabled) |
| D4PBCNoDevopsUpdate.Codeunit.al | No-op implementation for apps without DevOps integration |
| D4PBCDevOpsUpdate.Interface.al | Interface defining DevOps update contracts |
| D4PBCDevOpsEnvironments.Enum.al | Enum for supported DevOps platforms |
| D4PBCPTEApp.Table.al | Table storing PTE app metadata including DevOps configuration |
| D4PBCPTEAppVersion.Table.al | Table storing individual app version records |
| D4PBCPTEAppsList.Page.al | List page for managing PTE apps with version retrieval action |
| D4PBCPTEAppCard.Page.al | Card page for PTE app details with versions factbox |
| D4PBCPTEAppVersionCard.Page.al | Card page for app version details with download capability |
| D4PPTEAppVersionsFactBox.Page.al | FactBox showing available versions for a PTE app |
| D4PBCDevOpsOrganization.Table.al | Table for storing DevOps organizations with PAT tokens |
| D4PBCDevOpsOrgList.Page.al | List page for managing DevOps organizations |
| D4PBCInputToken.Page.al | Dialog page for PAT token input |
| D4PPTEObjectRangeList.page.al | Added table relation and auto-population from PTE Apps |
| D4PPTEObjectRange.table.al | Added procedure to copy values from PTE App record |
| Translation files (multiple) | Updated with new translatable strings for the feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@TowerMyhrer I started reviewing, but in the meanwhile fixed the (minor) enhancements on a separate branch, since I had no access to the fork. See TowerMyhrer#1 Above is just clutter / styling / UX. I'm not fully understanding the actual functional requirement (besides the needs to create a 'PTE App' table) on what 'PTE management' actually tries to solve.
|
I will add the possibility to have several ranges. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 26 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 44 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Please review |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 44 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 44 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| using D4P.CCMS.Nuget; | ||
|
|
||
| page 62033 "D4P BC PTE App List" |
There was a problem hiding this comment.
Page ID 62033 is also used by other newly added pages in this PR ("D4P PTE App Versions FactBox" and "D4P BC Input Token"). In AL, page object IDs must be unique, so this will fail to compile. Assign unique page IDs across these three page objects (keep one at 62033 and renumber the others).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 44 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| using D4P.CCMS.Nuget; | ||
|
|
||
| page 62051 "D4P BC PTE App Card" |
There was a problem hiding this comment.
This page object ID (62035) conflicts with the newly added list page D4P BC PTE App List which is also declared as page 62035. AL page IDs must be unique; change one of the page IDs to a free number and update any references (e.g., CardPageId/Run calls) accordingly.
| page 62051 "D4P BC PTE App Card" | |
| page 62036 "D4P BC PTE App Card" |
| field(Token; Token) | ||
| { | ||
| Caption = 'Personal Access Token'; | ||
| ToolTip = 'Specifies the Personal Access Token for DevOps organization access.'; | ||
| MultiLine = true; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| var | ||
| Token: Text[250]; |
There was a problem hiding this comment.
The PAT is captured and stored via a plain Text[250] variable and displayed unmasked (MultiLine). This increases the risk of accidental disclosure (screen sharing, screenshots) and also relies on implicit conversion from Text to SecretText in GetToken(). Prefer capturing the token as SecretText end-to-end (or, if the UI requires Text, apply masking via ExtendedDatatype = Masked and convert explicitly to SecretText before storing).
| field(Token; TokenPlain) | |
| { | |
| Caption = 'Personal Access Token'; | |
| ToolTip = 'Specifies the Personal Access Token for DevOps organization access.'; | |
| MultiLine = true; | |
| ExtendedDatatype = Masked; | |
| trigger OnValidate() | |
| begin | |
| Token := TokenPlain; | |
| end; | |
| } | |
| } | |
| } | |
| } | |
| var | |
| Token: SecretText; | |
| TokenPlain: Text[250]; |
| tabledata "D4P BC PTE App Version" = R, | ||
| tabledata "D4P BC DevOps Organization" = R, | ||
| tabledata "D4P BC Environment Operation" = R, | ||
| tabledata "D4P BC PTE Object Range" = R, |
There was a problem hiding this comment.
This permission set now includes both the legacy D4P PTE Object Range and the new D4P BC PTE Object Range. That’s fine if intentional, but note that D4P BC PTE Object Range appears to be added twice in this file (once in tabledata and once in table objects is expected; but ensure it’s not duplicated within the same section across the full file). If there are duplicates within the same Permissions = list in the full file, AL can fail compilation or at least bloat the permission definition—remove redundant entries.
| tabledata "D4P BC PTE Object Range" = R, |
| table "D4P PTE Object Range" = X, | ||
| table "D4P BC PTE App" = X, | ||
| table "D4P BC PTE App Version" = X, | ||
| table "D4P BC DevOps Organization" = X, | ||
| table "D4P BC Environment Operation" = X, | ||
| table "D4P BC PTE Object Range" = X, |
There was a problem hiding this comment.
This permission set now includes both the legacy D4P PTE Object Range and the new D4P BC PTE Object Range. That’s fine if intentional, but note that D4P BC PTE Object Range appears to be added twice in this file (once in tabledata and once in table objects is expected; but ensure it’s not duplicated within the same section across the full file). If there are duplicates within the same Permissions = list in the full file, AL can fail compilation or at least bloat the permission definition—remove redundant entries.
| ### Object RAnges | ||
|
|
||
|  |
There was a problem hiding this comment.
The link target DevOpsOrganization.md does not match the added documentation filename (dev-ops-organization.md), so the link will be broken. Also, the heading/image alt text uses inconsistent casing (RAnges). Update the link and normalize the text/casing to improve navigability and readability.
7 participants
This Pr vil give a own table for PTE Apps and their versions.
It is updating the versoions with help from the rest client for Nuget.
Github is tested and working as a source of the Nuget package but for azure devops it need the final touch from someone that have a Azure devops to test against.
Github is using a PAT as token for read access to package.
This PR fix issue #58