Skip to content

Avoid nil pointer error when you have issues without body #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
golemiso wants to merge 1 commit into
base: develop
Choose a base branch
from
+28 −25
Open

Avoid nil pointer error when you have issues without body #2543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 28 additions & 25 deletions libs/ci/github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,12 @@ func (svc GithubService) ListIssues() ([]*ci.Issue, error) {
// this is an pull request, skip
continue
}

allIssues = append(allIssues, &ci.Issue{ID: int64(*issue.Number), Title: *issue.Title, Body: *issue.Body})
var body string
if issue.Body != nil {
// github issue body is optional, so we need to check if it is nil
body = *issue.Body
}
allIssues = append(allIssues, &ci.Issue{ID: int64(*issue.Number), Title: *issue.Title, Body: body})
}
if resp.NextPage == 0 {
break
Expand Down Expand Up @@ -264,14 +268,16 @@ func (svc GithubService) DeleteComment(id string) error {

type GithubCommentReaction string

const GithubCommentPlusOneReaction GithubCommentReaction = "+1"
const GithubCommentMinusOneReaction GithubCommentReaction = "-1"
const GithubCommentLaughReaction GithubCommentReaction = "laugh"
const GithubCommentConfusedReaction GithubCommentReaction = "confused"
const GithubCommentHeartReaction GithubCommentReaction = "heart"
const GithubCommentHoorayReaction GithubCommentReaction = "hooray"
const GithubCommentRocketReaction GithubCommentReaction = "rocket"
const GithubCommentEyesReaction GithubCommentReaction = "eyes"
const (
GithubCommentPlusOneReaction GithubCommentReaction = "+1"
GithubCommentMinusOneReaction GithubCommentReaction = "-1"
GithubCommentLaughReaction GithubCommentReaction = "laugh"
GithubCommentConfusedReaction GithubCommentReaction = "confused"
GithubCommentHeartReaction GithubCommentReaction = "heart"
GithubCommentHoorayReaction GithubCommentReaction = "hooray"
GithubCommentRocketReaction GithubCommentReaction = "rocket"
GithubCommentEyesReaction GithubCommentReaction = "eyes"
)

func (svc GithubService) CreateCommentReaction(id string, reaction string) error {
commentId, err := strconv.ParseInt(id, 10, 64)
Expand Down Expand Up @@ -354,23 +360,23 @@ func (svc GithubService) CreateCheckRun(name string, status string, conclusion s

ctx := context.Background()
checkRun, resp, err := client.Checks.CreateCheckRun(ctx, owner, repoName, opts)

// Log rate limit information
if resp != nil {
limit := resp.Header.Get("X-RateLimit-Limit")
remaining := resp.Header.Get("X-RateLimit-Remaining")
reset := resp.Header.Get("X-RateLimit-Reset")

if limit != "" && remaining != "" {
limitInt, _ := strconv.Atoi(limit)
remainingInt, _ := strconv.Atoi(remaining)

// Calculate percentage remaining
var percentRemaining float64
if limitInt > 0 {
percentRemaining = (float64(remainingInt) / float64(limitInt)) * 100
}

// Log based on severity
if remainingInt == 0 {
slog.Error("GitHub API rate limit EXHAUSTED",
Expand Down Expand Up @@ -401,17 +407,17 @@ func (svc GithubService) CreateCheckRun(name string, status string, conclusion s
}
}
}

return checkRun, err
}

type GithubCheckRunUpdateOptions struct {
Status *string
Status *string
Conclusion *string
Title *string
Summary *string
Text *string
Actions []*github.CheckRunAction
Title *string
Summary *string
Text *string
Actions []*github.CheckRunAction
}

func (svc GithubService) UpdateCheckRun(checkRunId string, options GithubCheckRunUpdateOptions) (*github.CheckRun, error) {
Expand Down Expand Up @@ -497,8 +503,8 @@ func (svc GithubService) UpdateCheckRun(checkRunId string, options GithubCheckRu
}

opts := github.UpdateCheckRunOptions{
Name: *existingCheckRun.Name,
Output: output,
Name: *existingCheckRun.Name,
Output: output,
Actions: newActions,
}

Expand Down Expand Up @@ -906,7 +912,6 @@ func ProcessGitHubEvent(ghEvent interface{}, diggerConfig *digger_config.DiggerC
"action", *event.Action)

changedFiles, err := ciService.GetChangedFiles(prNumber)

if err != nil {
slog.Error("could not get changed files", "error", err, "prNumber", prNumber)
return nil, nil, 0, fmt.Errorf("could not get changed files")
Expand All @@ -924,7 +929,6 @@ func ProcessGitHubEvent(ghEvent interface{}, diggerConfig *digger_config.DiggerC
"comment", *event.Comment.Body)

changedFiles, err := ciService.GetChangedFiles(prNumber)

if err != nil {
slog.Error("could not get changed files", "error", err, "prNumber", prNumber)
return nil, nil, 0, fmt.Errorf("could not get changed files")
Expand Down Expand Up @@ -979,7 +983,6 @@ func ProcessGitHubPullRequestEvent(payload *github.PullRequestEvent, diggerConfi
"action", *payload.Action)

changedFiles, err := ciService.GetChangedFiles(prNumber)

if err != nil {
slog.Error("could not get changed files", "error", err, "prNumber", prNumber)
return nil, nil, prNumber, fmt.Errorf("could not get changed files")
Expand Down
Loading