V3.7.0 #377
V3.7.0 #377
Conversation
build: Add support for python 3.14 and drop for python 3.11
# Conflicts: # src/diffpy/utils/_deprecator.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 10 +1
Lines 516 567 +51
=========================================
+ Hits 516 567 +51
🚀 New features to boost your workflow:
|
|
@sbillinge ready for review/merge. I also added a light tests for the deprecator just to be thorough |
| ) | ||
|
|
||
|
|
||
| def generate_deprecation_docstring(new_name, removal_version, new_base=None): |
There was a problem hiding this comment.
It isnt used anywhere. my idea with it was to have it as a helper that could easily print the docstring then the user could copy/paste the docstring where it needs to go. I removed it because I felt like this was overkill but if you think its helpful we can add it back
There was a problem hiding this comment.
I wrote it because I was hoping for more uniformity. You could just print the docstring template and use it.
src/diffpy/utils/_deprecator.py
Outdated
|
|
||
|
|
||
| def build_deprecation_message( | ||
| def deprecation_message( |
There was a problem hiding this comment.
don't we want our function names to be verbs not nouns? I think I prefer build_deprecation_message?
|
@sbillinge ready for review again |
|
@cadenmyers13 ok, I left a comment. Everything else looks fine. Thanks for getting the verb-name function going. |
3 participants
closes #376