Skip to content

Conversation

@john-halloran
Copy link

This version should also fix the line length complaints.

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (john-development@d18b930). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             john-development     #181   +/-   ##
===================================================
  Coverage                    ?   77.50%           
===================================================
  Files                       ?        3           
  Lines                       ?       40           
  Branches                    ?        0           
===================================================
  Hits                        ?       31           
  Misses                      ?        9           
  Partials                    ?        0           
Files with missing lines Coverage Δ
tests/test_snmf_optimizer.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is teh reason for the noqa's? Can they be removed?

@john-halloran
Copy link
Author

What is teh reason for the noqa's? Can they be removed?

They were to skip line length checks on some lines, but have now been removed.

@sbillinge sbillinge merged commit f10029a into diffpy:john-development Feb 8, 2026
6 checks passed
@john-halloran john-halloran deleted the rho-zero-case branch February 8, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants