refactor: change get_objective_function into a static method and getter

[john-halloran]

• get_objective_function() now passes to compute_objective_function()
• wrote unit tests for compute_objective_function()

[sbillinge]

do we know why tests are not running in CI?

[john-halloran]

do we know why tests are not running in CI?

Out of credits, maybe? Otherwise I have no idea.

[john-halloran]

It is saying:
[Invalid workflow file: .github/workflows/tests-on-pr.yml#L12](https://github.com/diffpy/diffpy.snmf/actions/runs/19680434710/workflow) error parsing called workflow ".github/workflows/tests-on-pr.yml" -> "Billingegroup/release-scripts/.github/workflows/_tests-on-pr.yml@v0" : workflow was not found. See https://docs.github.com/actions/learn-github-actions/reusing-workflows#access-to-reusable-workflows for more information.

[sbillinge]

Ok, can we fix that on this pr?

[john-halloran]

Ok, can we fix that on this pr?

Yes, it's fixed now. It broke because the scripts were moved to scikit-package from release-scripts and it didn't know to look for them there. Worth noting if this happens elsewhere.

[john-halloran]

These issues cropping up are making me realize the package is a bit "dirty", probably because it originated from an old fork. I can keep patching things but a better solution might be to re-cut the package with scikit-package.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (john-development@d83619e). Learn more about missing BASE report.

Additional details and impacted files

@@                 Coverage Diff                 @@
##             john-development     #174   +/-   ##
===================================================
  Coverage                    ?   77.50%           
===================================================
  Files                       ?        3           
  Lines                       ?       40           
  Branches                    ?        0           
===================================================
  Hits                        ?       31           
  Misses                      ?        9           
  Partials                    ?        0           

Files with missing lines	Coverage Δ
tests/test_snmf_optimizer.py	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[john-halloran]

It passed now. The codecov score is cheating a bit, because one of the tests spins up the whole class. Ideally we'd get all our coverage through unit tests, and this PR is meant to be a step in that direction.

[sbillinge]

I will merge this. But I agree, let's do a quick recut so we are sure everything is up to date. Let's also migrate to 3.12 - 3.14 while we are at it