refactor: reconstruct separate from residuals#169
Merged
sbillinge merged 3 commits intodiffpy:john-developmentfrom Aug 20, 2025
Merged
refactor: reconstruct separate from residuals#169sbillinge merged 3 commits intodiffpy:john-developmentfrom
sbillinge merged 3 commits intodiffpy:john-developmentfrom
Conversation
Contributor
|
very nice. Good thinking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the reconstruction of an sNMF style matrix is a fundamental operation that may have other uses, it didn't make sense for it to bundled with the calculation of residuals.
This is helpful, for example, if the user wants to directly compare their source matrix to its sNMF approximation.