Import default property to support raw-loader default configuration#15
Open
alessandro308 wants to merge 3 commits intodgsmith2:masterfrom
Open
Import default property to support raw-loader default configuration#15alessandro308 wants to merge 3 commits intodgsmith2:masterfrom
alessandro308 wants to merge 3 commits intodgsmith2:masterfrom
Conversation
|
If using webpack 5 you can use the asset/resource loader:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are using raw-loader to load HTML file, it returns an object with the default properties to be compatible with ES6 standard. This tool uses ES5 syntax ( required(..) ) so we need to access to default value explicitly.
Another possible solution, instead of these changes, is to upgrade raw-loader to 4.0.0 and use
esModules: falseproperties but this introduces two different problems:esModules:falsecan be too much restrictive