Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and improvements to the JiraTime application, focusing on better Jira authentication support, improved user experience, and UI updates. The most significant changes are the addition of Jira email-based authentication (for Jira Cloud), validation and handling of the new email field, UI improvements for version display and feedback, and minor icon and usability tweaks.
Jira authentication improvements:
jiraEmailfield toAppSettingsand updating the authentication logic increateHeadersto use Basic Auth with email and token for Jira Cloud, and Bearer token for Jira Server/DC. [1] [2] [3]jiraEmailfield, ensuring it is persisted and loaded correctly.Settings UI and validation:
Ticket logging improvements:
addWorklogfunction for both manual and timer-based logging. [1] [2] [3] [4]UI and usability updates:
Build and workflow updates:
manifest.jsonandpackage.jsonto1.3.0and added a build-time define for__APP_VERSION__using Vite. [1] [2] [3]no-prs.ymlworkflow to restrict PR closing to non-owners and non-bot users.