Open
Conversation
…vday_pwa into feat/login-page
+ remove firstname, name + add passwordconfirm + implement ValidatorFn for matching password Co-Authored-By: NemareLethiere <nemarelethiere@users.noreply.github.com>
Collaborator
|
For the api requests we should implement a basicservice which can be used across different servises.: |
artifactdev
requested changes
Sep 4, 2019
| constructor(private http: HttpClient) { } | ||
|
|
||
| getAll() { | ||
| return this.http.get<User[]>(`${environment.apiUrl}/users`); |
Collaborator
There was a problem hiding this comment.
API Endpoints should be moved into an enum
| </div> | ||
| <div class="form-group"> | ||
| <label for="password">Password</label> | ||
| <label for="password">Passwort</label> |
Collaborator
There was a problem hiding this comment.
We should generate components for inputs where label is only shown when a label is given by input. Input type, state (readonly ...) should be configurable too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We build a small login page with this tutorial
We've already implemented:
Do not merge. This pr is just for the progress.