Add $CLOUT tooltips to CC holdings/price on wallet page#427
Open
netpro2k wants to merge 1 commit intodeso-protocol:mainfrom
Open
Add $CLOUT tooltips to CC holdings/price on wallet page#427netpro2k wants to merge 1 commit intodeso-protocol:mainfrom
netpro2k wants to merge 1 commit intodeso-protocol:mainfrom
Conversation
Contributor
|
great work @netpro2k ! do you think if we can display it instead of hover event ? |
Author
Yep I do think there are better solutions to this with some further design changes but that would probably require some more back and forth. This feels obviously better than what we have now without having to really sacrifice anything. I think a site wide solution to this should be figured out, but that's a bigger discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent price volatility it has been hard to tell what is happening to the value of CC holdings. It would be nice to be able to see values in $CLOUT instead of USD.
This PR adds a simple system tooltip (title attribute) to the wallet total, CC price, and CC cashout values to show the equivalent values in $CLOUT.
Ultimately this is something that should probably happen site wide anywhere a price is displayed (along with the ability to change the default denomination to $CLOUT or BTC) but that is a much bigger change and probably involves some design decisions.
This is the lowest effort, highest impact, version of that.