Open
Conversation
|
This already has a number of merge conflicts. |
This commit adds a new error type that is returned from the JS API. It has fields to describe the location (specifier + line + col) of an error, in addition to storing the error message.
lucacasonato
force-pushed
the
error_type
branch
from
78ccefa to
17affaa
Compare
Member
Author
Originally based off the wrong branch - fixed now. |
dsherret
approved these changes
Sep 27, 2022
| message: String, | ||
| specifier: Option<String>, | ||
| line: Option<usize>, | ||
| column: Option<usize>, |
Member
There was a problem hiding this comment.
If there's a line, then there's a column so these could be combined to be behind a single Option to make it easier for consumers.
| struct EszipError { | ||
| message: String, | ||
| specifier: Option<String>, | ||
| line: Option<usize>, |
Member
There was a problem hiding this comment.
Maybe add a doc saying what kind of indexes the line and column are. I believe the line is 1-indexed and column is 1-indexed character index (not byte)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new error type that is returned from the JS API. It
has fields to describe the location (specifier + line + col) of an
error, in addition to storing the error message.