[Deepin-Kernel-SIG] [linux 6.12.y] [Deepin] arm64: deepin_arm64_desktop_defconfig: enable I2C_HID_ACPI #1527
Conversation
deepin inclusion category: bugfix enable i2c hid acpi for touchpad use. Tested-in NF301B. Link: https://www.bxc.com.cn/productinfo31.html Signed-off-by: Wentao Guan <guanwentao@uniontech.com> (cherry picked from commit 503e7e8) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnables the I2C HID over ACPI driver in the Deepin ARM64 desktop defconfig so that touchpads using this interface are supported on NF301B-class devices. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Ensure the new
I2C_HID_ACPIoption is placed near related I2C/HID config options indeepin_arm64_desktop_defconfigto keep the defconfig organized and easier to maintain. - Consider expanding the commit message slightly to clarify why this is enabled only for the Deepin ARM64 desktop defconfig (e.g., specific hardware dependency or broader applicability) so future maintainers understand the scope.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure the new `I2C_HID_ACPI` option is placed near related I2C/HID config options in `deepin_arm64_desktop_defconfig` to keep the defconfig organized and easier to maintain.
- Consider expanding the commit message slightly to clarify why this is enabled only for the Deepin ARM64 desktop defconfig (e.g., specific hardware dependency or broader applicability) so future maintainers understand the scope.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Cryolitia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Enables the ACPI-backed HID-over-I2C transport driver in the Deepin arm64 desktop defconfig to restore/enable touchpad support on ACPI-based arm64 desktop systems (tested on NF301B).
Changes:
- Enable
CONFIG_I2C_HID_ACPI=mindeepin_arm64_desktop_defconfigto support HID-over-I2C devices enumerated via ACPI (e.g., touchpads).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
deepin inclusion
category: bugfix
enable i2c hid acpi for touchpad use.
Tested-in NF301B.
Link: https://www.bxc.com.cn/productinfo31.html
(cherry picked from commit 503e7e8)
Summary by Sourcery
Bug Fixes: