Skip to content

[Deepin-Kernel-SIG] [linux 6.12.y] [Deepin] arm64: deepin_arm64_desktop_defconfig: enable I2C_HID_ACPI #1527

Open
opsiff wants to merge 1 commit intodeepin-community:linux-6.12.yfrom
opsiff:linux-6.12.y-2026-03-05-config
Open

[Deepin-Kernel-SIG] [linux 6.12.y] [Deepin] arm64: deepin_arm64_desktop_defconfig: enable I2C_HID_ACPI #1527
opsiff wants to merge 1 commit intodeepin-community:linux-6.12.yfrom
opsiff:linux-6.12.y-2026-03-05-config

Conversation

@opsiff
Copy link
Member

@opsiff opsiff commented Mar 5, 2026

deepin inclusion
category: bugfix

enable i2c hid acpi for touchpad use.

Tested-in NF301B.
Link: https://www.bxc.com.cn/productinfo31.html

(cherry picked from commit 503e7e8)

Summary by Sourcery

Bug Fixes:

  • Fix missing touchpad functionality on arm64 Deepin desktop systems by enabling the I2C HID ACPI driver in the defconfig.

deepin inclusion
category: bugfix

enable i2c hid acpi for touchpad use.

Tested-in NF301B.
Link: https://www.bxc.com.cn/productinfo31.html
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
(cherry picked from commit 503e7e8)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enables the I2C HID over ACPI driver in the Deepin ARM64 desktop defconfig so that touchpads using this interface are supported on NF301B-class devices.

File-Level Changes

Change Details Files
Enable the I2C HID over ACPI driver in the Deepin ARM64 desktop default configuration to fix touchpad support.
  • Set the I2C_HID_ACPI configuration option to be built-in or modular in the arm64 Deepin desktop defconfig
  • Aligns the Deepin arm64 desktop configuration with upstream/cherry-picked configuration enabling I2C HID ACPI devices
arch/arm64/configs/deepin_arm64_desktop_defconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Ensure the new I2C_HID_ACPI option is placed near related I2C/HID config options in deepin_arm64_desktop_defconfig to keep the defconfig organized and easier to maintain.
  • Consider expanding the commit message slightly to clarify why this is enabled only for the Deepin ARM64 desktop defconfig (e.g., specific hardware dependency or broader applicability) so future maintainers understand the scope.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Ensure the new `I2C_HID_ACPI` option is placed near related I2C/HID config options in `deepin_arm64_desktop_defconfig` to keep the defconfig organized and easier to maintain.
- Consider expanding the commit message slightly to clarify why this is enabled only for the Deepin ARM64 desktop defconfig (e.g., specific hardware dependency or broader applicability) so future maintainers understand the scope.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@Cryolitia Cryolitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Cryolitia
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables the ACPI-backed HID-over-I2C transport driver in the Deepin arm64 desktop defconfig to restore/enable touchpad support on ACPI-based arm64 desktop systems (tested on NF301B).

Changes:

  • Enable CONFIG_I2C_HID_ACPI=m in deepin_arm64_desktop_defconfig to support HID-over-I2C devices enumerated via ACPI (e.g., touchpads).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants