Conversation
c2cfb9d to
9c6c369
Compare
src/collections/map.rs
Outdated
| })) | ||
| }, | ||
| ForceInsertPoint::InsertPoint(insert_point) => match insert_point.insert_kind { | ||
| Exact { leaf_node_ptr } => { |
There was a problem hiding this comment.
| Exact { leaf_node_ptr } => { | |
| InsertKind::Exact { leaf_node_ptr } => { |
And could you remove the use [...]::InsertKind::Exact from somewhere up above? I think I missed it last review
| fn is_send<T: Send>() {} | ||
| fn is_sync<T: Sync>() {} | ||
|
|
||
| fn prefix_is_send<'a, K: Sync + 'a, V: Sync + 'a, A: Sync + Allocator + 'a>() { |
There was a problem hiding this comment.
nit: these are named prefix_ when they're testing subtree iter
|
I've also pondered the naming of these APIs and I'll like to rename them to: My thinking was that then all the prefix operations are grouped by starting with the same thing. Also would have symmetry with the existing Do you have any preferences around these names? |
|
Also would you mind updating the |
I have no preferences for these names. |
fe30b7c to
a019229
Compare
|
Alright, I think I addressed everything you mentioned. |
a019229 to
2d3de1d
Compare
Adds more operations that allow complex manipulation of trees using prefix operations. Such as `get_prefix_key_value_mut` which returns the stored key together with a mutable reference to the value. An entry api has been added for `force_insert` operations, this entry api has been added to the fuzzer.
2d3de1d to
e119ad7
Compare
declanvk
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing those comments!
|
I'll try to cut a release somewhat soon |
After trying to use the prefix operations implemented in #50, I ran into some missing operations, which I implemented here.
Adds more operations that allow complex manipulation of trees using prefix operations.
Such as
get_prefix_key_value_mutwhich returns the stored key together with a mutable reference to the value.An entry api has been added for
force_insertoperations, this entry api has been added to the fuzzer.