Pass colalign argument through to tabulate
#97
Merged
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tabulate_adapter.adapter(), permit the colalign argument to be passed in kwargs. This argument can be used by the application to set known desirable column alignments based on column types, without expensive numparse checks. In addition, this works reliably with nullable numeric columns, whereas the numparse logic does not.
rolandwalker
added a commit
to dbcli/mycli
that referenced
this pull request
Jan 24, 2026
After dbcli/cli_helpers#97 we can set the alignment on a per-column basis using the colalign parameter. In this PR we upgrade cli_helpers and set colalign for columns with a numeric type. This is more performant than using tabulate's numparse capability, and unlike numparse, works on nullable numeric columns. The default alignment for numeric columns is changed from left to right, on the basis that this is the default for the vendor client. However, the user is free to change it back in ~/.myclirc .
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
tabulate_adapter.adapter(), permit thecolalignargument to be passed inkwargs.This argument can be used by the application to set known desirable column alignments based on column types, without expensive numparse checks.
In addition, this works reliably with nullable numeric columns, whereas the numparse logic does not.
xref #96 which never was able to work.
xref dbcli/mycli#1102 which this intends to fix.
Checklist
CHANGELOG.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install), and ranblackon my code.