Require numPoints >= 3 for NaturalCubicSpline and NaturalQuinticSpline#137
Open
CodeReclaimers wants to merge 1 commit intodavideberly:masterfrom
Open
Require numPoints >= 3 for NaturalCubicSpline and NaturalQuinticSpline#137CodeReclaimers wants to merge 1 commit intodavideberly:masterfrom
CodeReclaimers wants to merge 1 commit intodavideberly:masterfrom
Conversation
With 2 points, RowReduce accesses mDelta[1] which is out of bounds (mDelta has only 1 element), causing a heap-buffer-overflow. The multi-segment solver requires at least 2 segments (3 points) for its row reduction to work correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RowReduceaccessesmDelta[1]out of bounds (heap-buffer-overflow). The multi-segment solver requires at least 2 segments (3 points). Changed assertion fromnumPoints >= 2tonumPoints >= 3in bothNaturalCubicSplineandNaturalQuinticSpline, and updated documentation comment.Test plan
NaturalQuinticSpline.h:336)🤖 Generated with Claude Code