Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces YAML-based configuration loading for DataSHIELD login information, moving login/config structures to Pydantic models and wiring config discovery into the login builder.
Changes:
- Add
DSConfig/ refactorDSLoginInfoto Pydantic models, with YAMLload_from_file()and default-pathload()discovery/merge. - Extend
DSLoginBuilderto optionally pre-populate logins from configuration by server name; switch failure output fromprintto logging. - Add pytest coverage for YAML parsing/validation and update docs + dependencies/version.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
datashield/interface.py |
Adds Pydantic models and YAML config loading/merging via default config file search paths. |
datashield/api.py |
Allows DSLoginBuilder to load named servers from config; uses logging for connection failure reporting. |
tests/test_config.py |
New tests covering YAML config parsing and Pydantic validation behaviors. |
README.md |
Documents config search paths, merge behavior, and YAML schema. |
pyproject.toml |
Bumps version to 0.3.0 and adds pydantic + PyYAML dependencies. |
uv.lock |
Updates lockfile to include new runtime dependencies. |
datashield/__init__.py |
Exposes DSConfig from the package top-level. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.