Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements an R sessions API for the datashield-opal package, introducing server-side R session management capabilities. The changes include a new OpalRSession class, updates to OpalConnection for session handling, and modifications to dependencies and project configuration.
Changes:
- Implements R sessions API with lifecycle management (start, check status, close)
- Updates dependencies from git URLs to pinned package versions
- Adds development dependencies for data visualization (matplotlib, pandas)
- Adds Jupyter notebook example demonstrating the new functionality
- Modifies test to use different resource identifiers
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pyproject.toml | Version downgrade to 0.2.0, dependency updates to pinned versions, new dev dependencies, wheel packaging exclusions |
| datashield_opal/impl.py | New OpalRSession class implementing RSession interface, modified OpalConnection with session management, added authentication check |
| tests/test_api_analysis.py | Updated resource ID in test from RSRC.CNSIM1 to RSRC.CNSIM2 for server2 |
| examples/datashield.py.ipynb | New comprehensive example notebook demonstrating DataSHIELD operations including sessions, resource assignments, and visualizations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.