Draft: Authentication Service Model and Views#3
Draft
OscarMoya wants to merge 4 commits intodatahangar:mainfrom
Draft
Draft: Authentication Service Model and Views#3OscarMoya wants to merge 4 commits intodatahangar:mainfrom
OscarMoya wants to merge 4 commits intodatahangar:mainfrom
Conversation
msune
reviewed
Jun 13, 2024
src/models/authentication.py
Outdated
| __tablename__ = "users" | ||
|
|
||
| id = Column(Integer, primary_key=True, index=True) | ||
| tenant_id = Column(Integer, index=True) # Not sure about this one |
Member
There was a problem hiding this comment.
I don't see DH being multi-tenant anytime soon. I would see RBAC fit the bill for most of the things, so I would add Roles"
Having said that, leave it. JIC.
Author
There was a problem hiding this comment.
Yes, I will make it nullable and optional so it does not slowdown the implementation
msune
reviewed
Jun 13, 2024
src/models/authentication.py
Outdated
| __tablename__ = "users" | ||
|
|
||
| id = Column(Integer, primary_key=True, index=True) | ||
| tenant_id = Column(Integer, index=True) # Not sure about this one |
Author
There was a problem hiding this comment.
ok, bear in mind that there are some providers (oAuth) that they don't have any name, just the email . This is OK as emails are unique and you don't need additional unique constrains on the DB. That being said, if you want we can do it optional and if not provided use the email as user-name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP work for the authentication service compatible with OAuth