Skip to content

feat(runtime): Implement streaming execution output (fixes #1813) #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tinodj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(runtime): Implement streaming execution output (fixes #1813) #1814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions packages/databricks-vscode/src/run/DatabricksRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,28 +181,38 @@ export class DatabricksRuntime implements Disposable {
);

this.state = "EXECUTING";
let outputPosition = 0;

const onStatusUpdate = (result: any) => {
if (result.results?.resultType === "text") {
const output = (result.results as any).data;
if (output && output.length > outputPosition) {
this._onDidSendOutputEmitter.fire({
type: "out",
text: output.substring(outputPosition),
filePath: program,
line: 0,
column: 0,
});
outputPosition = output.length;
}
}
};

const response = await executionContext.execute(
await this.compileCommandString(
program,
args,
syncDestinationMapper,
envVars
),
undefined,
onStatusUpdate,
this.token,
new Time(240, TimeUnits.hours)
);
const result = response.result;

if (result.results!.resultType === "text") {
this._onDidSendOutputEmitter.fire({
type: "out",
text: (result.results as any).data,
filePath: program,
line: 0,
column: 0,
});
} else if (result.results!.resultType === "error") {
if (result.results!.resultType === "error") {
const frames = parseErrorResult(result.results!);
for (const frame of frames) {
let localFile = "";
Expand Down