Conversation
So far this will only add the include directory to the library as well as to the compiler wrapper. If at some point some Boost module must be linked, it should be added to Boost.cmake.
|
Please be careful here. From my experience boost is a pain in the butt, not readily available on many machines (it took us ages to transition to C++14 because there may be machines that have ancient compilers...), and not stable between releases. Adding a new mandatory dependency further complicates building DASH. It is not clear to me which libraries you want to use and how that will help with the stuff @rkowalewski does/did. I think we should find a consensus on whether we want to pull in boost in the first place instead of blindly rushing it in, without a clear explanation of the benefits and essential things like the minimum version required etc. If we decide to include boost, can we integrate it into our source tree / build system to avoid external mandatory dependencies? If not, how do we avoid tripping over incompatibilities? |
|
I'm also not a big fan of adding boost. Like devreal already mentioned, boost will complicate things, especially on HPC systems. Put it on the agenda for the next meeting. |
|
As per the discussion at the F2F today:
|
We could eliminate much of our code if we just used Boost, e.g. much of the iterators and const-correctnes stuff @rkowalewski is currently working on. This PR adds the dependency to DASH.
So far this will only add the include directory to the library target as well
as to the compiler wrapper.
If at some point some Boost module must be linked, it should be added to
Boost.cmake.
How can I add Boost to our CI Docker images?