Move to Safari drive to try to make safari testing less flaky#2598
Move to Safari drive to try to make safari testing less flaky#2598
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
|
@natebosch – I fixed some things up and added a changelog entry |
| Runtime.safari: ExecutableSettings( | ||
| macOSExecutable: '/Applications/Safari.app/Contents/MacOS/Safari', | ||
| macOSExecutable: 'safaridriver', | ||
| environmentOverride: 'SAFARI_EXECUTABLE', |
There was a problem hiding this comment.
Should we change this to SAFARI_DRIVER_EXECUTABLE?
I'm a little worried about breaking existing users of this variable, but I think overall I still lean towards supporting only the safaridriver flow.
| port.toString(), | ||
| ]); | ||
| } catch (_) { | ||
| stderr.writeln('safaridriver failed to start.'); |
There was a problem hiding this comment.
I don't think we write directly to stderr except for in higher layers of the runner.
I think we want to throw a LoadException and we can put the extra user help there.
Similar below.
| # Authenticate safaridriver for the current session | ||
| sudo safaridriver --enable |
There was a problem hiding this comment.
As far as I can tell, the sudo isn't universally required. I think we can show the command without it.
What does "for the current session" mean here?
| # Authenticate safaridriver for the current session | |
| sudo safaridriver --enable | |
| # Authenticate safaridriver (may need sudo) | |
| safaridriver --enable |
2 participants
No description provided.