Remove test_api copies of scaffolding functions#2030
Draft
Remove test_api copies of scaffolding functions#2030
Conversation
There are definitions in `test_core` which override the `_declarer` to work even when the test script is run directly instead of through the test runner. The definitions from `test_api` should not be used anywhere currently.
Add an override on `matcher` for `test_api` for breaking version change.
Member
Author
|
This is currently incompatible with |
natebosch
added
the
next-breaking-release
natebosch
added a commit
to natebosch/flutter
that referenced
this pull request
Jun 5, 2023
The members which are currently hidden may get removed from `package:test_api` because they have no uses. dart-lang/test#2030 Switch to a `show` and list all the exported APIs. This is currently a no-op change, and is forward compatible with the breaking change when it lands. A `show` is also safer than a `hide` when exporting across package boundaries. Adding a new member to a library _can be_ breaking, but is often treated as non-breaking. If a new member is added to `package:test_api/scaffolding.dart` it will need to be manually added to the list to be usable from `package:flutter_test`, but we anyways want to add a CHANGELOG entry for user facing changes.
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 6, 2023
The members which are currently hidden may get removed from `package:test_api` because they have no uses. dart-lang/test#2030 Switch to a `show` and list all the exported APIs. This is currently a no-op change, and is forward compatible with the breaking change when it lands. A `show` is also safer than a `hide` when exporting across package boundaries. Adding a new member to a library _can be_ breaking, but is often treated as non-breaking. If a new member is added to `package:test_api/scaffolding.dart` it will need to be manually added to the list to be usable from `package:flutter_test`, but we anyways want to add a CHANGELOG entry for user facing changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are definitions in
test_corewhich override the_declarertowork even when the test script is run directly instead of through the
test runner. The definitions from
test_apishould not be used anywherecurrently.