[WIP] Named timers in Durable Task #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salaboy
force-pushed
the
1532-named-timers
branch
from
a6fd062 to
4bcbbf0
Compare
Collaborator
Author
|
@javier-aliaga, we need to validate that this creates timers with the same names as the Go SDK. We also need to validate this against Catalyst, my current approach is to use a modified version in the Java SDK and then run examples to validate the same output. |
famarting
reviewed
Sep 8, 2025
client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java
Outdated
Show resolved
Hide resolved
famarting
reviewed
Sep 8, 2025
client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java
Outdated
Show resolved
Hide resolved
famarting
reviewed
Sep 8, 2025
| .setId(id) | ||
| .setCreateTimer(CreateTimerAction.newBuilder().setFireAt(ts)) | ||
| .setCreateTimer(CreateTimerAction.newBuilder() | ||
| .setName(name + "-timer-" + id).setFireAt(ts)) |
There was a problem hiding this comment.
don't build a name here, just use whatever is provided
Collaborator
Author
There was a problem hiding this comment.
@famarting I need to add the id here to the name, right? So all the instances of the timer have different name, that include the ID
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
force-pushed
the
1532-named-timers
branch
from
268b8a9 to
c64af4c
Compare
famarting
reviewed
Sep 8, 2025
famarting
reviewed
Sep 8, 2025
Collaborator
Author
|
Closing because now Durable Task is in the Java SDK and we have a new PR: dapr/java-sdk#1628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
based on: dapr/durabletask-go@2fcc964
resolves dapr/java-sdk#1532
Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information