Fix #14423: Add support for Cairo, GLib, GTK and ATK version check macros #8147
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CAIRO_VERSION_ENCODE() to fix undefined function-like macro error.
Add GLIB_CHECK_VERSION(), GTK_CHECK_VERSION() and ATK_CHECK_VERSION() to fix undefined function-like macro error.
b4n
force-pushed
the
cairo-gtk-version-check
branch
from
4204890 to
3bb7367
Compare
|
chrchr-github
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without those known to cppcheck, it now bails out with something like this:
So define them in a best-effort fashion:
1as there's no better alternative than an arbitrary boolean value, and those checks are usually guarding newer or optional code paths, so it conceptually makes more sense to have a truthy value.