fix: deadlock in std_log_impl macro on write failure#151
Open
kpraneet wants to merge 1 commit intodaboross:mainfrom
Open
fix: deadlock in std_log_impl macro on write failure#151kpraneet wants to merge 1 commit intodaboross:mainfrom
kpraneet wants to merge 1 commit intodaboross:mainfrom
Conversation
The std_log_impl macro, deadlocks when a write operation fails. This occurs because the stream lock is still held when fallback_on_error attempts to write the error message.
The fix modifies the macro to properly scope the stream lock:
- Ensure lock is released after write attempts by using explicit scope
- Handle lock release before error propagation via result?
- Maintain same behavior for both meta-logging and standard logging paths
Before:
write!(self.stream.lock(), "{}", msg)?;
// Lock held during error propagation
After:
let result = {
let mut writer = self.stream.lock();
write!(writer, "{}", msg)
}; // Lock released here
result?; // Error propagation after lock release
This prevents the deadlock by ensuring the stream lock is always released before any error handling occurs through fallback_on_error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The std_log_impl macro, deadlocks when a write operation fails. This occurs because the stream lock is still held when fallback_on_error attempts to write the error message.
The fix modifies the macro to properly scope the stream lock:
result?Before:
After:
This prevents the deadlock by ensuring the stream lock is always released before any error handling occurs through fallback_on_error.
Fixes #150
Validation: