Conversation
chipbarnaby
changed the title
nealkruis
approved these changes
Feb 20, 2026
Contributor
nealkruis
left a comment
nealkruis
left a comment
There was a problem hiding this comment.
@chipbarnaby two conditionals that aren't likely needed any more. We can clean them up later if needed.
Comment on lines
+6473
to
+6477
| #if 1 // CHDHW fan power fix, 2/2026 | ||
| rs_outFan = rs_runF * fanPwr * BtuperWh; // fan heat, Btuh | ||
| #else | ||
| x rs_outFan = rs_runF * fanPwr * Top.tp_subhrDur * BtuperWh; // WRONG fan heat, Btuh | ||
| #endif |
Contributor
There was a problem hiding this comment.
I don't think we need to keep the conditional any longer.
src/curvemap.cpp
Outdated
Comment on lines
247
to
252
| #if defined( _DEBUG) | ||
| if (isnan(pa_capRef)) | ||
| { printf("\npa_CapRef = nan"); | ||
| pa_capRef = 0.; | ||
| } | ||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Identical rework and cleanup of RSYS code as in PR #608 EXCEPT performance-map-based air source heat pump heating models DO NOT include "Cutler curve" adjustments in simulation and autosize calcs.
Recent CHDHW fan power fix IS included.