Re-enable wasm32-unknown-emscripten target.#840
Conversation
|
Note that #include <iostream>
#include <stdexcept>
extern "C" {
void hello() {
std::cout << "Hello, world!" << std::endl;
throw std::invalid_argument( "received negative value" );
}
} |
|
bors try --target wasm32-unknown-emscripten |
tryBuild succeeded: |
Uses a trick described in rust-lang/rust/issues#85821#issuecomment-969369677. Note that this still allows it to run, despite there seemingly being no entry point: this has no effect on the resulting code. Related to cross-rs#609. Partially fixes cross-rs#839.
Emilgardis
left a comment
There was a problem hiding this comment.
should be added to readme too, but otherwise, nice catch!
Update `xtask target-info` to support solaris and emscripten targets, and update their info in the README, showing the targets are enabled and with their updated toolchain versions.
|
I've updated the README and also updated the extract target info for this, since I also forgot to do this for solaris. Feel free to merge this whenever ready. |
|
bors r+ |
|
Build succeeded: |
|
The upstream Rust issue has since been resolved (rust-lang/rust#8582 (comment)), and Emscripten has also made a change to support older Rust versions again (emscripten-core/emscripten#17222). The emscripten fix has made it to the latest release (https://hub.docker.com/layers/emsdk/emscripten/emsdk/3.1.14/images/sha256-4c3e0a0dac61430b719e82118ae9b2c7480902a2713267e80fa296d39f7ab921). So this PR should probably be reverted in favor of a bump to the emscripten version used in the Dockerfile |
Uses a trick described in rust-lang/rust/issues#85821#issuecomment-969369677. Note that this still allows it to run, despite there seemingly being no entry point: this has no effect on the resulting code.
Related to #609. Partially fixes #839.