xtask/build_docker_image: Add windows/amd64 platform handling#1672
xtask/build_docker_image: Add windows/amd64 platform handling#1672MarijnS95 wants to merge 1 commit intocross-rs:mainfrom
windows/amd64 platform handling#1672Conversation
Emilgardis
left a comment
There was a problem hiding this comment.
looks good, minor nit about the todo comment
|
regarding buildx/buildkit, there's experimental support for it, see this list for their progress: https://github.com/moby/buildkit/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%2Fwindows-wcow and this issue for the popular setup-buildx-action https://redirect.github.com/docker/setup-buildx-action/issues/292 |
As listed at for example https://docs.docker.com/build/building/multi-platform/. Allows using `--platform windows/amd64` rather than `--platform x86_64-pc-windows-msvc`.
359863b to
7e1105f
Compare
|
@Emilgardis thanks, so it's What's the right way to use this As far as I understand |
|
We have a msvc image here already, we just don't publish its not certain it's actually any good: https://github.com/cross-rs/cross-toolchains/blob/main/docker/Dockerfile.aarch64-pc-windows-msvc-cross, it does not use the container platform cross in general does not compile through emulation, we cross-compile. Although, we do emulation on aarch64 hosts for now because we don't have the infrastructure rn to make linux/arm64 images published (see #1636) |
|
@Emilgardis thanks for confirming, I see now (should have opened the docker image before): it's emulating native MSVC in an Ubuntu Docker image on Trying this now on my dev machine, it is bindmounting It's also surprising that Finally, the |
As listed at for example https://docs.docker.com/build/building/multi-platform/.
Allows using
--platform windows/amd64rather than--platform x86_64-pc-windows-msvc.I didn't manage to use this in GitHub Actions CI on
windows-latestjust yet because it complains that--platformis not understood, and the help text suggests thatbuildxisn't installed in these images in the first place:Docker-Buildx)Docker-Buildx)