Open
Conversation
asmjs has been in limbo for years. Modern rustc does not even acknowledge it as an existing target anymore. As such, reap it out. This commit also removes emscripten.sh, which has not been used anywhere even prior to this change.
purplesyringa
force-pushed
the
kill-asmjs
branch
from
8ba62db to
6c8e99e
Compare
Emilgardis
approved these changes
Jan 21, 2025
Member
Emilgardis
left a comment
Emilgardis
left a comment
There was a problem hiding this comment.
Thank you! I'll get this merged once CI is fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asmjs has been in limbo for years. Modern rustc does not even acknowledge it as an existing target anymore. As such, reap it out.
This commit also removes emscripten.sh, which has not been used anywhere even prior to this change.
My apologies for not running tests on this commit before pushing. They are all failing at this moment, and I don't think it's related to my changes.