Skip to content

update mill to use prebuilt launcher #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajrnz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update mill to use prebuilt launcher #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions apps/resources/mill-interactive.json
View file
Open in desktop

This file was deleted.

12 changes: 5 additions & 7 deletions apps/resources/mill.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
{
"mainClass": "mill.main.client.MillClientMain",
"repositories": [
"central"
"central",
"typesafe:ivy-releases"
],
"launcherType": "prebuilt",
"dependencies": [
"com.lihaoyi::mill-dev:latest.stable"
],
"properties": {
"jna.nosys": "true",
"MILL_CLASSPATH": "${java.class.path}",
"MILL_VERSION": "${mill-dev.version}"
}
"name": "mill",
"prebuilt": "https://github.com/com-lihaoyi/mill/releases/download/${version}/${version}"
Copy link
Member

@alexarchambault alexarchambault Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not use a prebuilt JAR here. If it were a binary, it would make sense, but as it's a JAR, we can just have coursier pull the right class path.

Copy link
Author

@ajrnz ajrnz Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a jar, it is the standard mill startup shell script which only changes very seldom (except for the embedded version number).

This is all that is required to bootstrap mill and removes the need for the mill-interactive config. Maybe there is a better way of doing this in coursier - I've only examined this configuration from a cursory perspective.

I'll like to be able to install / update mill from cs as it a great way to get the whole ecosystem up and running, however the current configuration doesn't work correctly as it doesn't use the standard startup script and @lefou et al. refuse to look at mill bugs installed from coursier as mill -i etc doesn't work etc, which is understandable.

I understood that the recent changes meant that the standard scripts for sbt could now be used. Can the same be done for mill?

}