Open
Conversation
|
Hi, is there somebody interested in reviewing / merging this patch ? |
pbruneton
pushed a commit
to criteo-forks/spymemcached
that referenced
this pull request
Aug 21, 2018
Related to BES-16032, this patch helps to gather more information about the issue encountered that kill the Memcached IO thread. Please note that this patch will not kill the Memcached IO thread which will continue to run. Previous known bug reports related to this issue are: couchbase#7 couchbase#17 Change-Id: If1d9887963e96ac6ee4a8ec0dd0c19626e521346 JIRA:WBSC-3570
tootedom
added a commit
to tootedom/herdcache
that referenced
this pull request
Sep 3, 2019
apply patch from https://code.google.com/archive/p/spymemcached/issues/192, referenced from couchbase/spymemcached#7
favila
referenced
this pull request
in useshortcut/spymemcached
Jan 14, 2022
Relicensing as Apache 2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys,
I push this patch in relation with the issue 192 from google code (https://code.google.com/p/spymemcached/issues/detail?id=192)
The bug date is from 2011 and it's still alive.
This issue caused the dead of the thread which reads in the input queue. An exception is thrown and not caught.
When the thread is dead, the input queue increases and when it's full, we get this exception:
The application crashes and we have to restart it.
Currently, we have the bug in production once by day or less. After we deployed the patch, we get this exception:
Not really speaking but the thread doesn't die and the application doesn't crash.