Add more form attributes by ElijahAhianyo · Pull Request #352 · cot-rs/cot

ElijahAhianyo · 2025-06-18T00:22:11Z

This PR adds more form attributes to various HTML elements in cot

codecov · 2025-06-18T00:49:34Z

Codecov Report

❌ Patch coverage is 92.91339% with 27 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
cot/src/form/fields.rs	90.11%	5 Missing and 21 partials ⚠️
cot/src/form/fields/files.rs	93.75%	0 Missing and 1 partial ⚠️

Flag	Coverage Δ
rust	`89.76% <92.91%> (+0.10%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
cot-core/src/html.rs	`97.65% <100.00%> (+0.20%)`	⬆️
cot/src/form/fields/attrs.rs	`100.00% <100.00%> (+100.00%)`	⬆️
cot/src/form/fields/files.rs	`93.08% <93.75%> (-0.07%)`	⬇️
cot/src/form/fields.rs	`89.06% <90.11%> (+0.81%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

seqre · 2026-02-10T18:46:52Z

cot-core/src/html.rs

+    /// Creates a new `HtmlTag` instance for a datalist element.
+    ///
+    /// # Examples
+    /// ```
+    /// use cot::html::HtmlTag;
+    /// let data_list = HtmlTag::data_list(vec!["Option 1", "Option 2"], "my-datalist");
+    /// let rendered = data_list.render();
+    /// ```


nit:

Suggested change

/// Creates a new `HtmlTag` instance for a datalist element.

///

/// # Examples

/// ```

/// use cot::html::HtmlTag;

/// let data_list = HtmlTag::data_list(vec!["Option 1", "Option 2"], "my-datalist");

/// let rendered = data_list.render();

/// ```

/// Creates a new `HtmlTag` instance for a [datalist] element.

///

/// # Examples

/// ```

/// use cot::html::HtmlTag;

/// let data_list = HtmlTag::data_list(vec!["Option 1", "Option 2"], "my-datalist");

/// let rendered = data_list.render();

/// ```

///

/// [datalist]: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/datalist

seqre · 2026-02-10T18:56:41Z

cot-core/src/html.rs

+            let l = item.as_ref();
+            let mut option = HtmlTag::new("option");
+            option.attr("value", l);
+            option.push_str(l);


As I look in the MDN docs and HTML standard, option only needs to have the content in the value field, not s a children.

Suggested change

option.push_str(l);

seqre · 2026-02-10T18:58:37Z

cot-core/src/html.rs

+    /// let rendered = data_list.render();
+    /// ```
+    #[must_use]
+    pub fn data_list<I, S>(list: I, id: &str) -> Self


I'm not sure if we should force providing id in the constructor, maybe getting rid of it and expecting users to do .attr("id", id") is enough?

seqre · 2026-02-11T20:42:57Z

cot/src/form/fields.rs

+    pub autocapitalize: Option<AutoCapitalize>,
+    /// Corresponds to the [`AutoComplete`] attribute in the HTML input element.
+    pub autocomplete: Option<AutoComplete>,


Those are global attributes so they apply to all HTML elements, maybe we should add some macro that will add them to every HTML element struct we create or via composition? What do you think @m4tx? 🤔

seqre · 2026-02-11T20:43:52Z

cot/src/form/fields.rs

+        if let Some(min_length) = self.custom_options.min_length {
+            tag.attr("minlength", min_length.to_string());
+        }
+
+        if let Some(placeholder) = &self.custom_options.placeholder {
+            tag.attr("placeholder", placeholder);
+        }
+        if let Some(readonly) = self.custom_options.readonly
+            && readonly
+        {
+            tag.bool_attr("readonly");
+        }
+        if let Some(autocomplete) = &self.custom_options.autocomplete {
+            tag.attr("autocomplete", autocomplete.to_string());
+        }
+
+        if let Some(size) = self.custom_options.size {
+            tag.attr("size", size.to_string());
+        }
+
+        if let Some(dir) = &self.custom_options.dir {
+            tag.attr("dir", dir.as_str());
+        }
+
+        if let Some(dirname) = &self.custom_options.dirname {
+            tag.attr("dirname", dirname);
+        }
+
+        if let Some(list) = &self.custom_options.list {
+            let list_id = format!("__{}_datalist", self.id());
+            tag.attr("list", &list_id);
+
+            let data_list = HtmlTag::data_list(list.clone(), &list_id);
+            tag.push_tag(data_list);
+        }
+


nit: can you sort them in the same order as field declaration in the struct?

seqre · 2026-02-11T20:44:14Z

cot/src/form/fields.rs

+
+        if let Some(min_length) = self.custom_options.min_length {
+            tag.attr("minlength", min_length.to_string());
+        }
+        if let Some(placeholder) = &self.custom_options.placeholder {
+            tag.attr("placeholder", placeholder);
+        }
+        if let Some(readonly) = self.custom_options.readonly
+            && readonly
+        {
+            tag.bool_attr("readonly");
+        }
+        if let Some(autocomplete) = &self.custom_options.autocomplete {
+            tag.attr("autocomplete", autocomplete.to_string());
+        }
+
+        if let Some(size) = self.custom_options.size {
+            tag.attr("size", size.to_string());
+        }
+


nit: can you sort them in the same order as field declaration in the struct?

seqre · 2026-02-11T20:44:30Z

cot/src/form/fields.rs

+        if let Some(placeholder) = &self.custom_options.placeholder {
+            tag.attr("placeholder", placeholder);
+        }
+        if let Some(readonly) = self.custom_options.readonly
+            && readonly
+        {
+            tag.bool_attr("readonly");
+        }
+        if let Some(autocomplete) = &self.custom_options.autocomplete {
+            tag.attr("autocomplete", autocomplete.to_string());
+        }
+
+        if let Some(size) = self.custom_options.size {
+            tag.attr("size", size.to_string());
+        }
+
+        if let Some(dir) = &self.custom_options.dir {
+            tag.attr("dir", dir.as_str());
+        }
+
+        if let Some(dirname) = &self.custom_options.dirname {
+            tag.attr("dirname", dirname);
+        }
+
+        if let Some(list) = &self.custom_options.list {
+            let list_id = format!("__{}_datalist", self.id());
+            tag.attr("list", &list_id);
+
+            data_list = Some(HtmlTag::data_list(list.clone(), &list_id));
+        }
+
        if let Some(value) = &self.value {
            tag.attr("value", value);
        }

+        if let Some(data_list) = data_list {
+            let mut wrapper = HtmlTag::new("div");
+            wrapper
+                .attr("id", format!("__{}_datalist_wrapper", self.id()))
+                .push_tag(tag)
+                .push_tag(data_list);
+            return write!(f, "{}", wrapper.render());
+        }


nit: can you sort them in the same order as field declaration in the struct?

seqre · 2026-02-11T20:46:38Z

cot/src/form/fields.rs

 impl HtmlSafe for EmailField {}

-impl_form_field!(IntegerField, IntegerFieldOptions, "an integer", T: Integer);
+impl_form_field!(IntegerField, IntegerFieldOptions, "an integer", T: Integer + Display);


Why was it needed here and below for float field?

seqre · 2026-02-11T20:48:26Z

cot/src/form/fields.rs

+        if let Some(max_length) = self.custom_options.max_length {
+            tag.attr("maxlength", max_length.to_string());
+        }
+        if let Some(min_length) = self.custom_options.min_length {
+            tag.attr("minlength", min_length.to_string());
+        }
+        if let Some(placeholder) = &self.custom_options.placeholder {
+            tag.attr("placeholder", placeholder);
+        }
+        if let Some(readonly) = self.custom_options.readonly
+            && readonly
+        {
+            tag.bool_attr("readonly");
+        }
+        if let Some(autocomplete) = &self.custom_options.autocomplete {
+            tag.attr("autocomplete", autocomplete.to_string());
+        }
+
+        if let Some(size) = self.custom_options.size {
+            tag.attr("size", size.to_string());
+        }
+
+        if let Some(dir) = &self.custom_options.dir {
+            tag.attr("dir", dir.as_str());
+        }
+
+        if let Some(dirname) = &self.custom_options.dirname {
+            tag.attr("dirname", dirname);
+        }
+
+        if let Some(list) = &self.custom_options.list {
+            let list_id = format!("__{}_datalist", self.id());
+            tag.attr("list", &list_id);
+
+            let data_list = HtmlTag::data_list(list, &list_id);
+            tag.push_tag(data_list);
+        }


nit: can you sort them in the same order as field declaration in the struct?

seqre · 2026-02-11T21:10:04Z

cot/src/form/fields/attrs.rs

+///
+/// [`list`]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#list
+#[derive(Debug, Clone, Default)]
+pub struct List(Vec<String>);


The linked docs about list attribute for <input> claim that:

The value given to the list attribute should be the id of a element located in the same document.

I understand that your approach was of simplicity, but I think we should first and foremost support the spec and then add conveniences for the users.

I'd say that new should take the id of datalist by default. Or even better, take a datalist struct, but now it's generic HtmlTag, which doesn't make it that much better.

Then, we can provide a convenience constructor, let's say from_list, that has the existing functionality.

github-actions bot added the C-lib Crate: cot (main library crate) label Jun 18, 2025

ElijahAhianyo and others added 5 commits July 12, 2025 18:08

Add more form attributes

4a4e498

chore(pre-commit.ci): auto fixes from pre-commit hooks

89708fa

wrap input and datalist in a div

3a2b7ae

remove multiple option

ae395e2

rebase

e6b2f3d

ElijahAhianyo force-pushed the elijah/more-form-attrs branch from 4824f19 to e6b2f3d Compare July 12, 2025 18:20

add more docs

e027797

ElijahAhianyo marked this pull request as ready for review February 8, 2026 20:05

Merge branch 'master' into elijah/more-form-attrs

c7ba160

ElijahAhianyo force-pushed the elijah/more-form-attrs branch from c55425b to c7ba160 Compare February 8, 2026 21:34

fix a number of issues

8b21224

ElijahAhianyo changed the title ~~wip: Add more form attributes~~ Add more form attributes Feb 8, 2026

increase cov

fe86f68

ElijahAhianyo requested review from m4tx and seqre February 9, 2026 11:44

clippy fix

6eb7fee

seqre reviewed Feb 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add more form attributes#352

Add more form attributes#352
ElijahAhianyo wants to merge 10 commits intocot-rs:masterfrom
ElijahAhianyo:elijah/more-form-attrs

ElijahAhianyo commented Jun 18, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 18, 2025 •

edited

Loading

Uh oh!

seqre Feb 10, 2026

Uh oh!

seqre Feb 10, 2026

Uh oh!

seqre Feb 10, 2026

Uh oh!

seqre Feb 11, 2026

Uh oh!

seqre Feb 11, 2026

Uh oh!

seqre Feb 11, 2026

Uh oh!

seqre Feb 11, 2026

Uh oh!

seqre Feb 11, 2026

Uh oh!

seqre Feb 11, 2026

Uh oh!

seqre Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ElijahAhianyo commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ElijahAhianyo commented Jun 18, 2025 •

edited

Loading

codecov bot commented Jun 18, 2025 •

edited

Loading