fix: correct type export and register custom element in the DOM#17
Merged
fix: correct type export and register custom element in the DOM#17
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves TypeScript consumer ergonomics for the corti-embedded web component by ensuring the published type entrypoint is correct and by adding DOM typings so the custom element is strongly typed when selected from the document.
Changes:
- Added a
CortiEmbeddedElementtype and registered'corti-embedded'inHTMLElementTagNameMapfor typed DOM access. - Updated the package
exports["."].typesentry to point atdist/web-index.d.ts(matching the TS entrypoint rather than the bundled JS). - Updated the TypeScript demo to rely on
querySelector('corti-embedded')typing and to make the event listener attachment null-safe.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/types/api.ts |
Adds a DOM element type and global HTMLElementTagNameMap augmentation for corti-embedded. |
package.json |
Fixes the exported types path to align with the TS-compiled web entrypoint (web-index). |
demo/demo.ts |
Updates demo typing approach for the element and adjusts imports / event listener attachment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
filipweilid
previously approved these changes
Mar 10, 2026
filipweilid
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.